Skip to content

Modify x.shape[0] to x_rope.shape[0] at line 188 #287

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 2 commits into from

Conversation

HungryFlo
Copy link

Since we just add RoPE to x_rope, so more precisely, we should use the cos_cached[:x_rope.shape[0]] and sin_cached[:x_rope.shape[0]] instead.

Since we just add RoPE to x_rope, so more precisely, we should use the cos_cached[:x_rope.shape[0]] and sin_cached[:x_rope.shape[0]] instead.
Modify `x.shape[0]` to `x_rope.shape[0]` at line 188
@vpj
Copy link
Member

vpj commented Jul 18, 2025

It's just the same value, we are using sequence length. Declared a variable to make it clear

@vpj vpj closed this Jul 18, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants